search

nix-community / crate2nix

rebuild only changed crates in CI with crate2nix and nix
https://nix-community.github.io/crate2nix/
Apache License 2.0
354 stars 83 forks source link

Allow users to configure default git branch name #206

Closed JonathanLorimer closed 10 months ago

Ericson2314 commented 2 years ago

(See https://github.com/kolloch/crate2nix/issues/205#issuecomment-941199516)

QAston commented 2 years ago

I had the same issue, but the root cause seems to be that the branch parameter in cargo is simply ignored by crate2nix and it's not the problem with the defaults.

Ericson2314 commented 2 years ago

@QAston sorry I didn't respond sooner, are you saying this fix is insufficient on its own?

QAston commented 2 years ago

Yes, I think so. Might be a different problem though - my cargo file pointed to the correct branch but it was ignored by cargo.nix, maybe in the OP's case there was no branch set in cargo files.

kolloch commented 10 months ago

Heyo @QAston / @Ericson2314,

I am doing some clean up work... I guess we can close this?

kolloch commented 10 months ago

(otherwise reopen)

QAston commented 10 months ago

no idea, I moved on from nix, I hope I never have to go back