search

nix-community / crate2nix

rebuild only changed crates in CI with crate2nix and nix
https://nix-community.github.io/crate2nix/
Apache License 2.0
354 stars 83 forks source link

Fix broken IFD build with Nix 2.4 #215

Closed balsoft closed 2 years ago

balsoft commented 2 years ago

Because of https://github.com/NixOS/nix/issues/5410, it's not possible to filter paths with references anymore. This prevented any IFD-based crate2nix usage. Fix this by not filtering the source when the Nix version used includes the breaking commit.

Works around #213

Ericson2314 commented 2 years ago

@balsoft Any idea why the tests are still failing?

balsoft commented 2 years ago

That's interesting

lorenzleutgeb commented 2 years ago

Could you please explain whether/how this relates to https://github.com/NixOS/nix/pull/5494? Thank you!

Ericson2314 commented 2 years ago

Because of https://github.com/NixOS/nix/pull/5494 Nix 2.5 should just work and we shouldn't need this workaround no more.

kolloch commented 2 years ago

Heyo, I merged this. Thank you @lorenzleutgeb !

Even thought this should not be necessary for long, I do like working tests meanwhile :)

symphorien commented 1 year ago

I see the issue is closed, could this workaround be removed for fixed nix versions ? I am using crate2nix without IFD and this causes the whole target directory to be copied...