search

nix-community / crate2nix

rebuild only changed crates in CI with crate2nix and nix
https://nix-community.github.io/crate2nix/
Apache License 2.0
354 stars 83 forks source link

update README for upstream mozilla-overlay issue #217

Closed danjl1100 closed 2 years ago

danjl1100 commented 2 years ago

Hello all,

I recently followed the README to use a specific rust version with nixpkgs-mozilla overlay, and ran into an upstream error (toRustTarget missing) noted in the upstream issue https://github.com/mozilla/nixpkgs-mozilla/issues/232.

Reading this comment https://github.com/mozilla/nixpkgs-mozilla/issues/232#issuecomment-707883876 it seems the solution is to inherit all packages from the chosen rustChannel, to avoid mixing overlay and non-overlay packages.

I'm a newbie when it comes to github contributions, so any advice is greatly appreciated.

Thanks :smiley:

Ericson2314 commented 2 years ago

What you wrote means inheriting no fields, not all of them, from the other attribute set, FYI.

I recently made something that might help with the upstream issue, so I will leave a comment there.