nix-community / crate2nix

rebuild only changed crates in CI with crate2nix and nix
https://nix-community.github.io/crate2nix/
Apache License 2.0
338 stars 82 forks source link

FIx `dep:` feature handling #258

Open Ericson2314 opened 1 year ago

Ericson2314 commented 1 year ago

https://github.com/kolloch/crate2nix/pull/252 is not quite correct, and we should fix it.

The issue is that while it enables deps based upon dep:, it doesn't properly remove the implicit feature that are no longer created when dep: is used.

This sort of disambiguation was a big point of why dep: was added in the first place, and so we should get it right.