nix-community / crate2nix

rebuild only changed crates in CI with crate2nix and nix
https://nix-community.github.io/crate2nix/
Apache License 2.0
338 stars 82 forks source link

please tag a release (10.0.1?) with #252 included #264

Closed ghost closed 9 months ago

ghost commented 1 year ago

Hi, dep:crate dependencies are starting to appear in projects. Fortunately crate2nix is ahead of the game! #252 added support for these. Would it be possible to tag a minor release somewhere after that merge so I can submit a PR to bump the crate2nix in nixpkgs?

Aside from needing #252, crate2nix does a wonderful job of building tvix; the following "just works" with ca2aef6de460a428e79d3920150fbe74aca87fdc:

git clone https://code.tvl.fyi/depot.git
cd depot/tvix/eval
crate2nix generate
nix build -f Cargo.nix -L rootCrate
result/bin/tvix-eval --expr 'let nix = "is so"; in with { nix = "crazy"; }; nix'

=> "is so" :: string

ghost commented 1 year ago

See also https://cl.tvl.fyi/c/depot/+/7350

Ericson2314 commented 1 year ago

I pushed some tags for a release candidate. @kolloch is there anything I should do as part of cutting an actual release?

bouk commented 1 year ago

@Ericson2314 it seems to me that tagging the release is all that's needed, then it can be bumped in nixpkgs 😃

ghost commented 11 months ago

Ping.

ghost commented 9 months ago

Hi, it's been almost a full year.

Could somebody please tag a release so we can get #252 into the 23.11 release of nixpkgs? An increasingly-large number of crates are broken without that.

kolloch commented 9 months ago

I pushed some tags for a release candidate. @kolloch is there anything I should do as part of cutting an actual release?

Sorry for missing these. I was hesitant to release because tests have been broken for Mac OS for a while. I recently fixed those.

There are some steps that I tend to do on release here:

https://github.com/nix-community/crate2nix/blob/master/release-steps.md

I should probably update them to a more modern workflow.

ghost commented 9 months ago

Thank you!