search

nix-community / crate2nix

rebuild only changed crates in CI with crate2nix and nix
https://nix-community.github.io/crate2nix/
Apache License 2.0
338 stars 82 forks source link

yusdacra improvements #269

Open NickHu opened 1 year ago

NickHu commented 1 year ago

These are improvements from @yusdacra's fork, in the feat/builtinfetchgit branch. I simply rebased them onto master (I saw a comment which suggested that they intended to upstream the changes anyway, so hopefully this is OK). In particular, this fixes #197 and #205, and possibly more. I have been using this patch set for a long time and it has worked very well.

Ericson2314 commented 1 year ago

Can we break this up a bit? For starters, I do not want to use builtins.fetchgit only (opt in is perhaps fine). I don't like fetching sources at eval time when it is not needed, and I don't like the impure (without sha256) fetching this does either.

There are other changes in there that are unambiguous improvements, so it would be nice to get those however.