search

nix-community / crate2nix

rebuild only changed crates in CI with crate2nix and nix
https://nix-community.github.io/crate2nix/
Apache License 2.0
338 stars 82 forks source link

Fix git deps with branches vendoring #278

Closed Ericson2314 closed 1 year ago

Ericson2314 commented 1 year ago

The branch name extraction logic was broken.

As a result of this, we can stop pregenerating the test for this case, demonstrating that tools.nix handles it.

Ericson2314 commented 1 year ago

@balsoft would you mind reviewing this, since I think you contributed large parts of the code I was modifying?

Ericson2314 commented 1 year ago

Thanks!