search

nix-community / dconf2nix

:feet: Convert dconf files (e.g. GNOME Shell) to Nix, as expected by Home Manager [maintainer=@jtojnar]
Apache License 2.0
228 stars 6 forks source link

dconf2nix should invert special case for empty string lists #34

Closed johanbrandhorst closed 3 years ago

johanbrandhorst commented 3 years ago

The fix for https://github.com/nix-community/home-manager/issues/769 introduced a special case for empty string lists when parsing the config. In short the following mapping happens:

[] -> @as []

See the logic here: https://github.com/nix-community/home-manager/commit/5d054abe6aa790da041d5ebd14fe44cc888d86bf#diff-1afc90afe9ca8ef2ec31b8fcee765e03d38679506e051053848e4b14aed57bbaR22.

dconf2nix should invert this logic, so the following mapping happens:

@as [] -> []

Currently, this configuration value maps to

"@as []"

This mapping breaks keybindings which unset keys.

johanbrandhorst commented 3 years ago

Thanks for the quick turnaround 😄

gvolpe commented 3 years ago

No problems, you caught me at home with some time to kill :)

I cut a new release: https://github.com/gvolpe/dconf2nix/releases/tag/v0.0.8, should hit nixpkgs in a couple of days.