Fix various issues - Githubissues

nix-community / dconf2nix

:feet: Convert dconf files (e.g. GNOME Shell) to Nix, as expected by Home Manager [maintainer=@jtojnar]

Apache License 2.0

218 stars 6 forks source link

Fix various issues #80

Closed AshleyYakeley closed 1 year ago

AshleyYakeley commented 1 year ago

Stop parser from hanging and eating up memory
Remove timeout mechanism entirely
Fix all build warnings
Follow the dconf dump format more accurately
Support variants and records

There might still be output issues.

AshleyYakeley commented 1 year ago

I think the backslash character literal parsing code may be wrong. I'm not sure how it's supposed to work.

gvolpe commented 1 year ago

Thanks for doing this! Can you also update this to ubuntu-latest so this can be verified on CI?

AshleyYakeley commented 1 year ago

OK done

AshleyYakeley commented 1 year ago

Sorry, I don't know anything about cachix. Does this work in master?

gvolpe commented 1 year ago

Need to bump the version of all actions to the latest, as this project hasn't seen an update in a while.

AshleyYakeley commented 1 year ago

OK, I think you'll have to do that?

gvolpe commented 1 year ago

You can do it on this PR in the same way you updated the ubuntu-latest value.

AshleyYakeley commented 1 year ago

The CI is broken in master, is it not? Fix it in master and then I'll merge it in.

jtojnar commented 1 year ago

Opened CI fix pr https://github.com/gvolpe/dconf2nix/pull/81