nix-community / dns.nix

A Nix DSL for DNS zone files [maintainers=@raitobezarius @kirelagin @Tom-Hubrecht]
Mozilla Public License 2.0
128 stars 24 forks source link

Take `lib` as argument in PTR type #12

Closed davidtwco closed 3 years ago

davidtwco commented 3 years ago

lib is provided as an argument to the record types, not pkgs, which meant that a missing required argument would be encountered when using nix-dns. Introduced by #8.

https://github.com/kirelagin/nix-dns/blob/bb554091237f959c4e34db958c355d24653bb6b8/dns/types/records/default.nix#L35

cc @kirelagin

kirelagin commented 3 years ago

Ugh, oooops.... Thanks for this!

I considered adding a PTR record to the example file that I kind of use as a dumb test, but figured that the PR is simple enough and that I wanted to implement real tests anyway, so......