nix-community / emacs-overlay

Bleeding edge emacs overlay [maintainer=@adisbladis]
486 stars 164 forks source link

Adding emacs-macport #214

Open knl opened 2 years ago

knl commented 2 years ago

As this overlay tracks various emacs packages, I'm wondering would it make sense to add emacs-macport to it as well? If yes, I'm willing to add it.

jhenahan commented 2 years ago

I actually used the overlay with the Mac port for a while just by specifying it as the package as you would normally for one of the overlay versions (since it's tracked in nixpkgs). I expect the hard part will be getting CI working, but then again I certainly wouldn't hate having cached builds for more Darwin stuff.

montchr commented 2 years ago

I actually used the overlay with the Mac port for a while just by specifying it as the package as you would normally for one of the overlay versions (since it's tracked in nixpkgs).

@jhenahan I didn't realize this was a thing. But re: "for a while": I'm curious why you stopped using it? Considering that it looks like emacs-mac (the source repo name on Bitbucket) now has native-comp support and it comes with the no-titlebar patch enabled by default, this is an interesting option to me.

I certainly wouldn't hate having cached builds for more Darwin stuff.

I certainly wouldn't hate that either. I would actually appreciate that quite a bit 😄

All that said, the version of emacs-mac/emacsMacport in nixpkgs (even the master branch) has not been updated to include support for native-comp / 28.0.92, but the source repo appears to add support for that version. https://bitbucket.org/mituharu/emacs-mac/src/work/

Considering that mituharu/railwaycat's repo ~is~ looks to me like a "fork" of Emacs with macOS-oriented patches applied, and the nixpkgs version is months out of date, I can totally see how emacs-mac would fit within the scope of emacs-overlay. The project has been around for quite a while and has a good reputation – e.g. doom-emacs recommends it as the most preferable Emacs package for macOS https://github.com/hlissner/doom-emacs/blob/master/docs/getting_started.org#with-homebrew

As this overlay tracks various emacs packages, I'm wondering would it make sense to add emacs-macport to it as well? If yes, I'm willing to add it.

@knl FWIW you've got my vote. I'm by no means involved in this project but let me know if you need a volunteer to test.

montchr commented 2 years ago

Related recent-ish updates regarding the version on nixpkgs:

Atemu commented 1 year ago

FYI, the emacsMacport integration PR linked above has been merged which means it does include native-comp now and can be used more easily for the purposes of the overlay.

You only need to pass a source and macportVersion.

dhess commented 1 year ago

Has anyone been able to get the upstreamed support to work on aarch64-darwin with this overlay? Mine always dies trying to build something clang- or llvm-related.

Atemu commented 1 year ago

This seems to be an issue on the Nixpkgs side though as other ports of this package work just fine.

dhess commented 1 year ago

Yes, it's a nixpkgs issue, I was just curious whether anyone else had seen the issue, since you mentioned emacsMacport.