nix-community / emacs-overlay

Bleeding edge emacs overlay [maintainer=@adisbladis]
506 stars 165 forks source link

emacsWithPackagesFromUsePackage: Don't avoid tangling use-package declarations in emacs-lisp blocks that use noweb-ref #354

Open ParetoOptimalDev opened 1 year ago

ParetoOptimalDev commented 1 year ago

This is low priority imo, not blocking me, and something I may or may not need in the future. Mostly this is for tracking purposes, feel free to close unless someone else cares.

I had to do:

-#+begin_src emacs-lisp :noweb-ref use-package-statements
+#+begin_src emacs-lisp

This is fine for now given I'm only using emacsWithPackagesFromUsePackage. In the future I'll probably make a version that works with and without nix though.

talyz commented 1 year ago

Hm, this sounds strange. I'll have to look into it further and test. The expected behavior is that you need to have :tangle yes in the argument list for the block to be tangled, so what's weird here is that the block gets tangled if you omit arguments. We don't currently parse the noweb-family of arguments.