Closed ParetoOptimalDev closed 9 months ago
Building without patches, but maybe this (untested) code removing only the bytecomp patch is better:
patches = lib.filter (patch: patch.name or (toString patch) != "bytecomp-revert.patch") old.patches;
Or perhaps I need to fix the bytecomp patch and it's still needed. It says its for #318 so I might not need it on my vanilla x86_64 linux but could be needed by others.
Oh forgot to update, that didn't work so I just rolled my flake back to an earlier version for now.
The following works for me:
Sadly I get this error that might be related to that patch somehow:
error: builder for '/nix/store/b5xg2r1zp8yiv9k3q7kxn4wzbn9z7004-emacs-beacon-20220730.100.drv' failed with exit code 255;
last 10 log lines:
> (if (consp x61) (let* ((x62 (car-safe x61)) (x63 (cdr-safe x61))) (if (null x63) (let ((package x58) (version x60) (commit x62)) (melpa2nix-build-package-1 (package-recipe-lookup package) version commit)))))
> (let* ((x60 (car-safe x59)) (x61 (cdr-safe x59))) (if (consp x61) (let* ((x62 (car-safe x61)) (x63 (cdr-safe x61))) (if (null x63) (let ((package x58) (version x60) (commit x62)) (melpa2nix-build-package-1 (package-recipe-lookup package) version commit))))))
> (if (consp x59) (let* ((x60 (car-safe x59)) (x61 (cdr-safe x59))) (if (consp x61) (let* ((x62 (car-safe x61)) (x63 (cdr-safe x61))) (if (null x63) (let ((package x58) (version x60) (commit x62)) (melpa2nix-build-package-1 (package-recipe-lookup package) version commit)))))))
> (let* ((x58 (car-safe command-line-args-left)) (x59 (cdr-safe command-line-args-left))) (if (consp x59) (let* ((x60 (car-safe x59)) (x61 (cdr-safe x59))) (if (consp x61) (let* ((x62 (car-safe x61)) (x63 (cdr-safe x61))) (if (null x63) (let ((package x58) (version x60) (commit x62)) (melpa2nix-build-package-1 (package-recipe-lookup package) version commit))))))))
> (if (consp command-line-args-left) (let* ((x58 (car-safe command-line-args-left)) (x59 (cdr-safe command-line-args-left))) (if (consp x59) (let* ((x60 (car-safe x59)) (x61 (cdr-safe x59))) (if (consp x61) (let* ((x62 (car-safe x61)) (x63 (cdr-safe x61))) (if (null x63) (let ((package x58) (version x60) (commit x62)) (melpa2nix-build-package-1 (package-recipe-lookup package) version commit)))))))))
> melpa2nix-build-package()
> command-line-1(("-L" "/build/package-build" "-l" "/nix/store/65hf8xsn31cindnpqcnha1w591jyvzhb-melpa2nix.el" "-f" "melpa2nix-build-package" "beacon" "20220730.100" "d09cfab21be800831644218e9c8c4433087951c0"))
> command-line()
> normal-top-level()
> Symbol's function definition is void: package--prepare-dependencies
Oh, sorry about that; maybe I should've let Emacs finish building before posting
I'm not sure if the bytecomp-revert patch is needed at all anymore since Mattias E. made some recent changes upstream...but anyway, I pushed some commits here to make sure the patch applies.
BTW, at the time of writing, the overlay's version of Emacs 30 works on nixos-unstable
but not release-23.11
since we merged https://github.com/NixOS/nixpkgs/pull/277331 fairly late. If this bothers anyone, let me know and I'll revert https://github.com/nix-community/emacs-overlay/pull/378 temporarily.
My flake metadata for emacs-overlay: