search

nix-community / emacs2nix

Automatically generate Nix expressions for Emacs packages
GNU General Public License v3.0
29 stars 17 forks source link

Downloads from EmacsWiki should be versioned #38

Closed binarin closed 7 years ago

binarin commented 7 years ago

EmacsWiki provides a way to download previous versions of files using urls like https://www.emacswiki.org/emacs/download/frame-cmds.el?revision=92

So I think that getFetcher at https://github.com/ttuegel/emacs2nix/blob/93b330f51f84e9f6f5ef57936816d6c84d7a05a8/src/Distribution/Melpa.hs#L239 should take some effort to determine proper revision and prevent package breakage after wiki edits.

I'm willing to implement this but I need to know which HTTP library I should add to .cabal and use.

ttuegel commented 7 years ago

Sounds good. Because the rest of emacs2nix is based on io-streams, I would suggest using http-streams for HTTP.

ttuegel commented 7 years ago

See also NixOS/Nixpkgs#24540 and NixOS/Nixpkgs#24824.