search

nix-community / ethereum.nix

Nix packages and NixOS modules for the Ethereum ecosystem. [maintainers=@aldoborrero,@brianmcgee,@selfuryon]
https://nix-community.github.io/ethereum.nix/
MIT License
101 stars 34 forks source link

fix: nimbus-beacon rest.allow-origin bad default #453

Closed iofq closed 7 months ago

iofq commented 7 months ago

If rest.enable is true and rest.allow-origin is not set, allow-origin defaults to null which can't be coerced to a string when building CLI flags for Nimbus. This MR fixes this behavior by adding a null check before building the flag.

iofq commented 7 months ago

Found and added commit for second bug, where data-dir flag was duplicated if it was non-default.