search

nix-community / ethereum.nix

Nix packages and NixOS modules for the Ethereum ecosystem. [maintainers=@aldoborrero,@brianmcgee,@selfuryon]
https://nix-community.github.io/ethereum.nix/
MIT License
103 stars 36 forks source link

mev-boost: 1.6.0 -> 1.7 #489

Closed jhvst closed 8 months ago

jhvst commented 8 months ago

Dencun update, tested that binary starts.

On the release page, the authors recommend Go 1.22. However, that is not package on Nix yet. Despite the recommendation, the program seems to compile and start fine.

ekimber commented 8 months ago

The flashbots release is 1.7 rather than 1.7.1

jhvst commented 8 months ago

Right, the page I linked is for 1.7 which is an alias of 1.7.0, but the release was followed a day later with 1.7.1. I thought it would make sense to just take the most recent version.

Le 1 mars 2024 à 20:43 +0000, Ed Kimber @.***>, a écrit :

The flashbots release is 1.7 rather than 1.7.1 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

jhvst commented 8 months ago

On a further thought, if there is a chance that someone missed a MEV block because of a minor version bump (I certainly don't want that), it seems more reasonable to have this at 1.7 just in case, or at least until nixpkgs is upgraded in regards to Go.

ekimber commented 8 months ago

Ah, I hadn't noticed the 1.7.1 tag. It seems to me a little unorthodox to upgrade a go major version in a patch version increment.