search

nix-community / flake-firefox-nightly

this provides an auto-updating flake for firefox-nightly-bin from nixpkgs-mozilla [maintainer=@colemickens, @Artturin]
48 stars 7 forks source link

Support non-nightly builds in pure mode #5

Closed andersk closed 1 year ago

andersk commented 1 year ago

Pull in the nixpkgs-mozilla fix I submitted upstream at mozilla/nixpkgs-mozilla#302.

Fixes #3.

colemickens commented 1 year ago

I think I actually have merge permissions in nixpkgs-mozilla. I'll review it and test it, if no one else comments in a few days I'll merge it.

(Aka, if you want, maybe go ahead and update this to point back to tip of nixpkgs-mozilla in anticipation of that fix being merged. That way I can merge both at once.)

andersk commented 1 year ago

Updated so "rev" still points at the PR commit (it definitely won’t work pointing at the current master), but without "ref": "refs/pull/302/head" (so the next nix flake update would pull from the new master).

colemickens commented 1 year ago

Well, I can't merge because there's conflicts, I can't figure out how to manually fix them, and the next update is going to basically do this anyway. If you want, you can update it to just drop the commented input? At least that way I can merge this :).

andersk commented 1 year ago

Sure, updated.