search

nix-community / home-manager

Manage a user environment using Nix [maintainer=@rycee]
https://nix-community.github.io/home-manager/
MIT License
7.08k stars 1.83k forks source link

Investigate GitHub actions test time blow up #1610

Closed berbiche closed 3 years ago

berbiche commented 4 years ago

Issue description

I have a feeling pkgs.formats is blowing up the pipeline. Currently all packages using pkgs.formats lack tests.

See:

I can successfully run all tests locally without any perceivable blow up in memory size or time.

Meta

Maintainer CC

@rycee @Infinisil (as the creator of pkgs.formats, do you have any idea as to how pkgs.formats could blow up the pipeline?)

berbiche commented 4 years ago

Looks like the tests started taking longer when i3status-rust was merged. It uses pkgs.formats for its configuration.

rycee commented 4 years ago

I suspect the long times somehow were related to the code format test. Because that test copies the checked out repository to the Nix store it will cause the entire repo to be read into memory and presumably it at some point got too large for the builder to handle. Running it locally the max residency of that test was a bit above 500MiB, which doesn't seem too bad but perhaps the builders are very constrained.

In any case, I don't know why it started being slow instead of killing the job with an out of memory error but the jobs seem to run again, now that I removed the format test.

berbiche commented 3 years ago

I wonder whether #1624 would resolve this issue?