search

nix-community / home-manager

Manage a user environment using Nix [maintainer=@rycee]
https://nix-community.github.io/home-manager/
MIT License
6.57k stars 1.73k forks source link

Refactor new-lines in i3-config like done for sway #2030

Open SebTM opened 3 years ago

SebTM commented 3 years ago

Issue description

As discussed in #2003 we should change the config-generation for i3 according to sway to not have random newlines if options are not set and get rid of trailing spaces. I already started working on that. (https://github.com/SebTM/home-manager/tree/i3-refactoring)

Meta

Maintainer CC

@sumnerevans @alexarice

sumnerevans commented 3 years ago

we should also fix any functions in lib/functions.nix (barStr for example). See #2135 for an example of why

stale[bot] commented 2 years ago

Thank you for your contribution! I marked this issue as stale due to inactivity. If this remains inactive for another 7 days, I will close this issue. Please read the relevant sections below before commenting.

If you are the original author of the issue

* If this is resolved, please consider closing it so that the maintainers know not to focus on this. * If this might still be an issue, but you are not interested in promoting its resolution, please consider closing it while encouraging others to take over and reopen an issue if they care enough. * If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

If you are not the original author of the issue

* If you are also experiencing this issue, please add details of your situation to help with the debugging process. * If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

Memorandum on closing issues

If you have nothing of substance to add, please refrain from commenting and allow the bot close the issue. Also, don't be afraid to manually close an issue, even if it holds valuable information.

Closed issues stay in the system for people to search, read, cross-reference, or even reopen--nothing is lost! Closing obsolete issues is an important way to help maintainers focus their time and effort.

sumnerevans commented 2 years ago

This is being worked on. Marked as pinned. I just have to get around to reviewing the corresponding PR.