bug: Seemingly trivial override breaks xmonad-compile build.

bitdizzy commented 2 years ago

Are you following the right branch?

[X] My Nixpkgs and Home Manager versions are in sync

Is there an existing issue for this?

[X] I have searched the existing issues

Issue description

I have just recently bumped my nixpkgs/unstable and home-manager/master after several months. I noticed that my xmonad configuration stopped compiling with this error message:

error: builder for '/nix/store/gss8865pbwd31s80fyl3pjy860swl3j6-xmonad-compile.drv' failed with exit code 1;
       last 3 log lines:
       > XMonad will use ghc to recompile, because neither "/build/xmonad-config/build" nor "/build/xmonad-config/stack.yaml" exists.
       > XMonad recompiling (forced).
       > xmonad: ghc: runProc: exec: does not exist (No such file or directory)
       For full logs, run 'nix log /nix/store/gss8865pbwd31s80fyl3pjy860swl3j6-xmonad-compile.drv'.

I read some discussion in the issue tracker about this, but couldn't see how I was triggering it at configuration build time. This is the configuration that does not build.

windowManager.xmonad = {
      haskellPackages = with pkgs.lib; pkgs.haskellPackages.extend (self: super: {
            taffybar = doJailbreak (addPkgconfigDepends (self.callCabal2nix "taffybar" sources.taffybar {}) [pkgs.gtk3]);
      });
      enable = true;
      config = ./xmonad/xmonad.hs;
      enableContribAndExtras = true;
      extraPackages = p: with p; [
        data-default
        lens
        taffybar
      ];
    }

So, taffybar is currently marked broken in the pkgs.haskellPackages I get. So, disabling it, and removing the haskellPackages override works:

windowManager.xmonad = {
      enable = true;
      config = ./xmonad/xmonad.hs;
      enableContribAndExtras = true;
      extraPackages = p: with p; [
        data-default
        lens
        # taffybar
      ];
    };

But! setting haskellPackages = pkgs.haskellPackages... fails?

windowManager.xmonad = {
      haskellPackages = pkgs.haskellPackages;
      enable = true;
      config = ./xmonad/xmonad.hs;
      enableContribAndExtras = true;
      extraPackages = p: with p; [
        data-default
        lens
        # taffybar
      ];
    };

error: builder for '/nix/store/1g40m0s7g6b66cjybwxna4azncpnhfx2-xmonad-compile.drv' failed with exit code 1;
       last 3 log lines:
       > XMonad will use ghc to recompile, because neither "/build/xmonad-config/build" nor "/build/xmonad-config/stack.yaml" exists.
       > XMonad recompiling (forced).
       > xmonad: ghc: runProc: exec: does not exist (No such file or directory)
       For full logs, run 'nix log /nix/store/1g40m0s7g6b66cjybwxna4azncpnhfx2-xmonad-compile.drv'.

As far as I can tell, this should amount to nothing: https://github.com/nix-community/home-manager/blob/f5e9879e74e6202e2dbb3628fad2d20eac0d8be4/modules/services/window-managers/xmonad.nix#L23-L33

But maybe my module set-up is very strange, and causing strange issues? I'm not sure how to proceed.

Maintainer CC

No response

System information

- system: `"x86_64-linux"`
 - host os: `Linux 5.10.118-hardened1, NixOS, 22.11 (Raccoon), 22.11pre-git`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.9.0`
 - channels(min): `""`
 - channels(root): `""`
 - nixpkgs: `/nix/store/3n0g1dqcs1giajn005sjr1rldd5bi4d0-source`

berbiche commented 2 years ago

Hi,

Do you happen to know what version of xmonad is being used to compile your configuration?

stale[bot] commented 1 year ago

Thank you for your contribution! I marked this issue as stale due to inactivity. Please be considerate of people watching this issue and receiving notifications before commenting 'I have this issue too'. We welcome additional information that will help resolve this issue. Please read the relevant sections below before commenting.

If you are the original author of the issue

* If this is resolved, please consider closing it so that the maintainers know not to focus on this. * If this might still be an issue, but you are not interested in promoting its resolution, please consider closing it while encouraging others to take over and reopen an issue if they care enough. * If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

If you are not the original author of the issue

* If you are also experiencing this issue, please add details of your situation to help with the debugging process. * If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

Memorandum on closing issues

Don't be afraid to manually close an issue, even if it holds valuable information. Closed issues stay in the system for people to search, read, cross-reference, or even reopen – nothing is lost! Closing obsolete issues is an important way to help maintainers focus their time and effort.