nix-community / home-manager

Manage a user environment using Nix [maintainer=@rycee]
https://nix-community.github.io/home-manager/
MIT License
6.68k stars 1.75k forks source link

bug: wayland.windowManager.sway.config.window.hideEdgeBorders doesn't allow `--i3` flag #3589

Open kchibisov opened 1 year ago

kchibisov commented 1 year ago

Are you following the right branch?

Is there an existing issue for this?

Issue description

The hide_edge_borders have an --i3 flag in addition to the options, so sway could follow i3 behavior wrt tabs. Given that hide_edge_borders is always generated it's impossible to convince sway to use that flag even via extraConfig.

The only way for now is to manually issue swaymsg 'hide_edge_borders --i3' smart from the startup module.

Maintainer CC

cc @oxalica @alexarice

System information

- system: `"x86_64-linux"`
 - host os: `Linux 6.1.3, NixOS, 23.05 (Stoat), 23.05.20230110.c07552f`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.12.0`
 - channels(root): `"home-manager, nixos"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
sumnerevans commented 1 year ago

Can you provide an example of what config line needs to be generated?

kchibisov commented 1 year ago

It's just you have hide_edge_borders --i3 smart instead of hide_edge_borders smart.

The syntax from the man page. hide_edge_borders [--i3] none|vertical|horizontal|both|smart|smart_no_gaps

So basically it's a bool whether to follow i3 or not.

stale[bot] commented 1 year ago

Thank you for your contribution! I marked this issue as stale due to inactivity. Please be considerate of people watching this issue and receiving notifications before commenting 'I have this issue too'. We welcome additional information that will help resolve this issue. Please read the relevant sections below before commenting.

If you are the original author of the issue

* If this is resolved, please consider closing it so that the maintainers know not to focus on this. * If this might still be an issue, but you are not interested in promoting its resolution, please consider closing it while encouraging others to take over and reopen an issue if they care enough. * If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

If you are not the original author of the issue

* If you are also experiencing this issue, please add details of your situation to help with the debugging process. * If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

Memorandum on closing issues

Don't be afraid to manually close an issue, even if it holds valuable information. Closed issues stay in the system for people to search, read, cross-reference, or even reopen – nothing is lost! Closing obsolete issues is an important way to help maintainers focus their time and effort.