nix-community / home-manager

Manage a user environment using Nix [maintainer=@rycee]
https://nix-community.github.io/home-manager/
MIT License
6.71k stars 1.76k forks source link

parse zellij keybinds KDL #4054

Open ymgyt opened 1 year ago

ymgyt commented 1 year ago

Description

I am trying to output the following zellij config

keybinds {
    normal {
        bind "Ctrl l" { SwitchToMode "Session"; }
        bind "Ctrl r" { SwitchToMode "Resize"; }
    }
}

my nix file

{ ... }: {
  programs.zellij = {
    enable = true;
    settings = {
      keybinds = {
        normal = {
          bind = [
            {
              _args = [ "Ctrl l" ];
              SwitchToMode = "Session";
            }
            { 
              _args = [ "Ctrl r" ];
              SwitchToMode = "Resize";
            }
          ];
        };
      };
    };
  };
}

But in fact, the following kdl is generated

keybinds {
    normal {
        bind {
            - "Ctrl l" {
                SwitchToMode "Session"
            }
            - "Ctrl r" {
                SwitchToMode "Resize"
            }
        }
    }
}

zellij failed to parse it

> zellij                                                                                                                            06/04/2023 03:51:20 AM

  × Failed to parse Zellij configuration
   ╭─[/home/ymgyt/.config/zellij/config.kdl:3:1]
 3 │            bind {
 4 │ ╭─▶            - "Ctrl l" {
 5 │ │                  SwitchToMode "Session"
 6 │ ├─▶            }
   · ╰──── Unsupported action: -
 7 │                - "Ctrl r" {
   ╰────
  help: For more information, please see our configuration guide: https://zellij.dev/documentation/configuration.html
ncfavier commented 1 year ago

@h7x4

antholeole commented 1 year ago

fix is otw: https://github.com/nix-community/home-manager/pull/4160/files

stale[bot] commented 11 months ago

Thank you for your contribution! I marked this issue as stale due to inactivity. Please be considerate of people watching this issue and receiving notifications before commenting 'I have this issue too'. We welcome additional information that will help resolve this issue. Please read the relevant sections below before commenting.

If you are the original author of the issue

* If this is resolved, please consider closing it so that the maintainers know not to focus on this. * If this might still be an issue, but you are not interested in promoting its resolution, please consider closing it while encouraging others to take over and reopen an issue if they care enough. * If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

If you are not the original author of the issue

* If you are also experiencing this issue, please add details of your situation to help with the debugging process. * If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

Memorandum on closing issues

Don't be afraid to manually close an issue, even if it holds valuable information. Closed issues stay in the system for people to search, read, cross-reference, or even reopen – nothing is lost! Closing obsolete issues is an important way to help maintainers focus their time and effort.

gotcha commented 10 months ago

I have added documentation: https://github.com/nix-community/home-manager/pull/4665

Feedback welcome !

stale[bot] commented 7 months ago

Thank you for your contribution! I marked this issue as stale due to inactivity. Please be considerate of people watching this issue and receiving notifications before commenting 'I have this issue too'. We welcome additional information that will help resolve this issue. Please read the relevant sections below before commenting.

If you are the original author of the issue

* If this is resolved, please consider closing it so that the maintainers know not to focus on this. * If this might still be an issue, but you are not interested in promoting its resolution, please consider closing it while encouraging others to take over and reopen an issue if they care enough. * If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

If you are not the original author of the issue

* If you are also experiencing this issue, please add details of your situation to help with the debugging process. * If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

Memorandum on closing issues

Don't be afraid to manually close an issue, even if it holds valuable information. Closed issues stay in the system for people to search, read, cross-reference, or even reopen – nothing is lost! Closing obsolete issues is an important way to help maintainers focus their time and effort.