bug: wayland.windowManager.sway.config.modifier is too restrictive

[grasegger]

Are you following the right branch?

• [X] My Nixpkgs and Home Manager versions are in sync

Is there an existing issue for this?

• [X] I have searched the existing issues

Issue description

I wanted to port my sway config to home manager, but the option wayland.windowManager.sway.config.modifier does not allow my modifier to be set:

set $mod Mod4+Alt+Shift+Ctrl

This modifier is easily reachable with one key because of my custom keyboard firmware, and sway allows it to be used without any problems.

Since sway is allowing it I was expecting home manager to follow sway for compatibility, but the option only allows for a few predefined values to be set.

Suggestion: Make the option a list of allowed values that get concatenated with a +. For example:

wayland.windowManager.sway.config.modifier = [ "Mod4" "Alt"];

Maintainer CC

@Scrumplex

System information

- system: `"x86_64-linux"`
 - host os: `Linux 6.6.8-200.fc39.x86_64, Fedora Linux, 39.20231230.0 (Sericea), nobuild`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - nixpkgs: `/nix/store/kh5mw1hsalj27ha1wfvksljxyaikcmyb-source`

[ambroisie]

I have an alternative suggestion: use type = with types; either (enum [ ... ]) str.

I appreciate the usage of enum to say "this is probably the value you'd want to use", but in effect mod could be set to any value...

[stale[bot]]

Thank you for your contribution! I marked this issue as stale due to inactivity. Please be considerate of people watching this issue and receiving notifications before commenting 'I have this issue too'. We welcome additional information that will help resolve this issue. Please read the relevant sections below before commenting.

If you are the original author of the issue

* If this is resolved, please consider closing it so that the maintainers know not to focus on this. * If this might still be an issue, but you are not interested in promoting its resolution, please consider closing it while encouraging others to take over and reopen an issue if they care enough. * If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

If you are not the original author of the issue

* If you are also experiencing this issue, please add details of your situation to help with the debugging process. * If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

Memorandum on closing issues

Don't be afraid to manually close an issue, even if it holds valuable information. Closed issues stay in the system for people to search, read, cross-reference, or even reopen – nothing is lost! Closing obsolete issues is an important way to help maintainers focus their time and effort.