bug: firefox bookmarks fail to apply from hm config

[andar1an]

Are you following the right branch?

• [X] My Nixpkgs and Home Manager versions are in sync

Is there an existing issue for this?

• [X] I have searched the existing issues

Issue description

Whether using bookmarks, or bookmarks and directories, bookmarks are not added to Firefox when configured with home-manager. May be related to #4860 if nested path is issue for that.

Occasionally the bookmark bar will also reappear when disabled, but opening another tab often will get rid of it.

Rough code example:

bookmarks and directories:

 programs.firefox = {
      profile0 = {
        isDefault = true;
        id = 0;
        path = "profiles/profile0";
        bookmarks = [
          {
            name = "toolbar";
            toolbar = true;
            bookmarks = [
               {
                 name = "";
                 url = "";
                 keyword = "";
               }
            ];
           }
         ] ;
     };
};

bookmarks:

 programs.firefox = {
      profile0 = {
        isDefault = true;
        id = 0;
        path = "profiles/profile0";
            bookmarks = [
               {
                 name = "";
                 url = "";
                 keyword = "";
               }
            ];
          };
};

Maintainer CC

@rycee @kira-bruneau

System information

- system: `"x86_64-linux"`
 - host os: `Linux 6.1.69, NixOS, 24.05 (Uakari), 24.05.20240102.bd645e8`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - channels(stephen): `""`
 - channels(root): `"nixos-23.05"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

[D3vil0p3r]

Im getting the same issue.

[britter]

Are you hitting #4731? It was fixed in Dec 23 but has not been released yet. I'm also waiting for it to be released with 24.05.

[nonetrix]

Getting same issue here :/

However, I am able to add bookmarks just not to the toolbar. So, not sure what is up here

[britter]

@nonetrix that's exactly what #4731 is about.

[nonetrix]

Sorry for my comment, not sure what I was doing wrong. I made it really late in the night so I think I was doing something dumb I will be completely honest, that has already been merged and now it seems to be working

[britter]

So I've updated to HM 24.05 and finally added the firefox module to my config https://github.com/britter/nix-configuration/pull/1. Unfortunately adding bookmarks to the toolbar does not seem to work. The bookmarks toolbar only contains the Import bookmarks... button. Not sure what's wrong.