nix-community / home-manager

Manage a user environment using Nix [maintainer=@rycee]
https://nix-community.github.io/home-manager/
MIT License
6.36k stars 1.7k forks source link

Incorrect mapping of quotes in string literal from nix config to .zshrc #4872

Open stefanwatt opened 6 months ago

stefanwatt commented 6 months ago

Are you following the right branch?

Is there an existing issue for this?

Issue description

This zsh.nix config:

...
programs.zsh = {
    enable = true;
    shellAliases = {
      nvim = ''nvim -c "lua require('persistence').load({last=true})"'';
    };
}
...

is translated into this alias in .zshrc:

alias nvim='nvim -c "lua require("persistence").load({last=true})"'

resulting in an error because the string literal is terminated by the double quote directly before persistence .

As you can see I intentionally used different types of quotes in the nix file to avoid this issue, but that information got lost in the mapping process.

Maintainer CC

@infinisil @uvNikita @rycee @marzipan

System information

- system: `"x86_64-linux"`
 - host os: `Linux 6.1.67, NixOS, 23.11 (Tapir), 23.11.1779.cf28ee258fd5`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - channels(stefan): `"home-manager-23.11.tar.gz, nixos-23.11"`
 - channels(root): `"home-manager-23.11.tar.gz, nixos-23.11"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
stale[bot] commented 3 months ago

Thank you for your contribution! I marked this issue as stale due to inactivity. Please be considerate of people watching this issue and receiving notifications before commenting 'I have this issue too'. We welcome additional information that will help resolve this issue. Please read the relevant sections below before commenting.

If you are the original author of the issue

* If this is resolved, please consider closing it so that the maintainers know not to focus on this. * If this might still be an issue, but you are not interested in promoting its resolution, please consider closing it while encouraging others to take over and reopen an issue if they care enough. * If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

If you are not the original author of the issue

* If you are also experiencing this issue, please add details of your situation to help with the debugging process. * If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

Memorandum on closing issues

Don't be afraid to manually close an issue, even if it holds valuable information. Closed issues stay in the system for people to search, read, cross-reference, or even reopen – nothing is lost! Closing obsolete issues is an important way to help maintainers focus their time and effort.