search

nix-community / home-manager

Manage a user environment using Nix [maintainer=@rycee]
https://nix-community.github.io/home-manager/
MIT License
6.86k stars 1.79k forks source link

Support setting a path for the `.jjconfig.toml` file through the `JJ_CONFIG` env var #5001

Open poliorcetics opened 8 months ago

poliorcetics commented 8 months ago

Description

jujutsu default config file location is ~/.jjconfig.toml.

This location is configurable via the JJ_CONFIG env var.

It would be nice for programs.jujutsu to support it. Some other programs already allow overriding their config file path that way.

Thanks!

SrEstegosaurio commented 7 months ago

Also, shouldn't it be placed by default under $XDG_CONFIG_HOME?

Related: https://github.com/martinvonz/jj/issues/84

poliorcetics commented 7 months ago

Ah, martinvonz/jj#85 uses dirs, its choices are often questioned on macOS (see https://github.com/dirs-dev/directories-rs/issues/47 for the longest discussion) :/ that's sad. Still, it will work on Linux at the very least

stale[bot] commented 4 months ago

Thank you for your contribution! I marked this issue as stale due to inactivity. Please be considerate of people watching this issue and receiving notifications before commenting 'I have this issue too'. We welcome additional information that will help resolve this issue. Please read the relevant sections below before commenting.

If you are the original author of the issue

* If this is resolved, please consider closing it so that the maintainers know not to focus on this. * If this might still be an issue, but you are not interested in promoting its resolution, please consider closing it while encouraging others to take over and reopen an issue if they care enough. * If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

If you are not the original author of the issue

* If you are also experiencing this issue, please add details of your situation to help with the debugging process. * If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

Memorandum on closing issues

Don't be afraid to manually close an issue, even if it holds valuable information. Closed issues stay in the system for people to search, read, cross-reference, or even reopen – nothing is lost! Closing obsolete issues is an important way to help maintainers focus their time and effort.

SrEstegosaurio commented 4 months ago

Still relevant to me.