nix-community / home-manager

Manage a user environment using Nix [maintainer=@rycee]
https://nix-community.github.io/home-manager/
MIT License
6.99k stars 1.81k forks source link

bug: Defining `programs.firefox.policies` creates a collision when installing floorp #5132

Open LovingMelody opened 7 months ago

LovingMelody commented 7 months ago

Are you following the right branch?

Is there an existing issue for this?

Issue description

If programs.firefox.policies is defined and floorp is included in home.packages build files due to a conflict:

       > error: collision between `/nix/store/ihpq883vc7bsv9rwnwwn86fpm7k496v6-floorp-11.10.5/lib/firefox/distribution/policies.json' and `/nix/store/hza1l5d6x7fng95r390qqhj7wqymzzpa-firefox-123.0.1/lib/firefox/distribution/policies.json'

Maintainer CC

@rycee @kira-bruneau

System information

- system: `"x86_64-linux"`
 - host os: `Linux 6.7.9, NixOS, 24.05 (Uakari), 24.05.20240312.21adc4f`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.21.0`
 - nixpkgs: `/nix/store/z9am1332wgfcsqf41978dki3754c67lq-source`
Cybolic commented 5 months ago

I think this is actually an issue with Floorp, not home-manager. From what I can tell from the code, Floorp still uses the same user distribution directories as Firefox (the link is for the definition of the mozilla directory, but this issue is of the same type). Personally, I've attempted to adapt one of LibreWolf's patches, in order to fix this, with no luck. In any case this should probably be filed as a bug against either Floorp or nixpkgs.

For now, I'm using this wrapper package to get Floorp running:

{ pkgs ? import <nixpkgs> {}, ... }: let
  pkg = pkgs.floorp;
in pkg.overrideAttrs (old: {
  name = "floorp-cleaned";

  buildCommand = /* bash */ ''
    set -euo pipefail

    set -x
    cp -rs --no-preserve=mode "${pkg.out}" "$out"
    set +x

    rm -R $out/lib/firefox
    rm -R $out/lib/mozilla
  '';

})
stale[bot] commented 1 month ago

Thank you for your contribution! I marked this issue as stale due to inactivity. Please be considerate of people watching this issue and receiving notifications before commenting 'I have this issue too'. We welcome additional information that will help resolve this issue. Please read the relevant sections below before commenting.

If you are the original author of the issue

* If this is resolved, please consider closing it so that the maintainers know not to focus on this. * If this might still be an issue, but you are not interested in promoting its resolution, please consider closing it while encouraging others to take over and reopen an issue if they care enough. * If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

If you are not the original author of the issue

* If you are also experiencing this issue, please add details of your situation to help with the debugging process. * If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

Memorandum on closing issues

Don't be afraid to manually close an issue, even if it holds valuable information. Closed issues stay in the system for people to search, read, cross-reference, or even reopen – nothing is lost! Closing obsolete issues is an important way to help maintainers focus their time and effort.