nix-community / home-manager

Manage a user environment using Nix [maintainer=@rycee]
https://nix-community.github.io/home-manager/
MIT License
6.36k stars 1.7k forks source link

Expose `modules/lib/file-type.nix` in `lib.hm` #5170

Open tomodachi94 opened 3 months ago

tomodachi94 commented 3 months ago

Description

The fileType function in modules/lib/file-type.nix is not exposed anywhere in lib. I am creating an out-of-tree module, and it would be neat if I could use this.

It looks like this was split from another file in 4f842d9f1b137d98ad4e6393b16b038bbab2bad2 without exposing the function in lib. It is called like so in the modules using it:

let
# ...
fileType = (import lib/file-type.nix {
    inherit homeDirectory lib pkgs;
  }).fileType;
# ...
in
{
# ...
}

Was this a deliberate design choice?

stale[bot] commented 3 weeks ago

Thank you for your contribution! I marked this issue as stale due to inactivity. Please be considerate of people watching this issue and receiving notifications before commenting 'I have this issue too'. We welcome additional information that will help resolve this issue. Please read the relevant sections below before commenting.

If you are the original author of the issue

* If this is resolved, please consider closing it so that the maintainers know not to focus on this. * If this might still be an issue, but you are not interested in promoting its resolution, please consider closing it while encouraging others to take over and reopen an issue if they care enough. * If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

If you are not the original author of the issue

* If you are also experiencing this issue, please add details of your situation to help with the debugging process. * If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

Memorandum on closing issues

Don't be afraid to manually close an issue, even if it holds valuable information. Closed issues stay in the system for people to search, read, cross-reference, or even reopen – nothing is lost! Closing obsolete issues is an important way to help maintainers focus their time and effort.

tomodachi94 commented 3 weeks ago

Still an issue, but I can take a look sometime this week.