nix-community / home-manager

Manage a user environment using Nix [maintainer=@rycee]
https://nix-community.github.io/home-manager/
MIT License
6.56k stars 1.73k forks source link

bug: nix version used by nix-direnv doesn't respect nix.package option #5260

Open adrian-gierakowski opened 4 months ago

adrian-gierakowski commented 4 months ago

Are you following the right branch?

Is there an existing issue for this?

Issue description

when I enable direnv with nix-direnv via:

  programs.direnv.enable = true;
  programs.direnv.nix-direnv.enable = true;

in my home-manager config (as opposed to nixos config) and when I change the version of nix to be used by the system via nix.package option

nix-direnv used by direnv call the default nix from nixpkgs, instead of the one set with nix.package

to fix this I need to set:

  programs.direnv.nix-direnv.package = pkgs.nix-direnv.override { nix = config.nix.package; };

I believe this should be done automatically, as it's done in the nixos module:

https://github.com/NixOS/nixpkgs/blob/1042fd8b148a9105f3c0aca3a6177fd1d9360ba5/nixos/modules/programs/direnv.nix#L53

Maintainer CC

No response

System information

- system: `"x86_64-linux"`
 - host os: `Linux 6.6.25, NixOS, 24.05 (Uakari), 24.05.20240406.ff0dbd9`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.21.1`
 - channels(root): `"nixos-22.05pre351617.942b0817e89"`
 - nixpkgs: `/nix/store/j10523yhkcc34478azkgcl70yzcx6j2j-source`
adrian-gierakowski commented 4 months ago

btw. I'm using nix.package = pkgs.nixVersions.nix_2_21 as it seems to be the only secure version of nix which doesn't reject files starting with a dot

stale[bot] commented 1 month ago

Thank you for your contribution! I marked this issue as stale due to inactivity. Please be considerate of people watching this issue and receiving notifications before commenting 'I have this issue too'. We welcome additional information that will help resolve this issue. Please read the relevant sections below before commenting.

If you are the original author of the issue

* If this is resolved, please consider closing it so that the maintainers know not to focus on this. * If this might still be an issue, but you are not interested in promoting its resolution, please consider closing it while encouraging others to take over and reopen an issue if they care enough. * If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

If you are not the original author of the issue

* If you are also experiencing this issue, please add details of your situation to help with the debugging process. * If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

Memorandum on closing issues

Don't be afraid to manually close an issue, even if it holds valuable information. Closed issues stay in the system for people to search, read, cross-reference, or even reopen – nothing is lost! Closing obsolete issues is an important way to help maintainers focus their time and effort.

adrian-gierakowski commented 1 month ago

Not stale

adrian-gierakowski commented 1 month ago

I can submit a fix if it would be welcome