search

nix-community / home-manager

Manage a user environment using Nix [maintainer=@rycee]
https://nix-community.github.io/home-manager/
MIT License
7.08k stars 1.83k forks source link

Upgrade `programs.taskwarrior` to use `taskwarrior3` #5310

Closed cloudlena closed 2 months ago

cloudlena commented 6 months ago

Currently, programs.taskwarrior.package defaults to pkgs.taskwarrior. A new version of Taskwarrior was released, so we should update the default to pkgs.taskwarrior3.

aktaboot commented 6 months ago

since the taskwarrior package is still in nixpkgs and people might not have migrated yet, I think we should still keep it to pkgs.taskwarrior. It can easily be set manually to taskwarrior3.

I don't think a breaking change should be imposed on users without notice

cloudlena commented 6 months ago

Thanks, @aktaboot. I see your point.

I'm not sure how this is handled usually. Would you just wait for some time and then change it later, or how would you proceed?

aktaboot commented 6 months ago

Yes, eventually it will roll out, but really unsure when.

stale[bot] commented 3 months ago

Thank you for your contribution! I marked this issue as stale due to inactivity. Please be considerate of people watching this issue and receiving notifications before commenting 'I have this issue too'. We welcome additional information that will help resolve this issue. Please read the relevant sections below before commenting.

If you are the original author of the issue

* If this is resolved, please consider closing it so that the maintainers know not to focus on this. * If this might still be an issue, but you are not interested in promoting its resolution, please consider closing it while encouraging others to take over and reopen an issue if they care enough. * If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

If you are not the original author of the issue

* If you are also experiencing this issue, please add details of your situation to help with the debugging process. * If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

Memorandum on closing issues

Don't be afraid to manually close an issue, even if it holds valuable information. Closed issues stay in the system for people to search, read, cross-reference, or even reopen – nothing is lost! Closing obsolete issues is an important way to help maintainers focus their time and effort.

mdietrich16 commented 3 months ago

What about services.taskwarrior-sync? AFAIK (still a newbie to Nix) there is no option to explicitly set the used taskwarrior pkg to taskwarrior3 instead of taskwarrior.

aktaboot commented 3 months ago

@mdietrich16 for taskwarrior3, you can just set programs.taskwarrior.package = pkgs.taskwarrior3; for the sync server module, I have a thing that I should upstream soon