search

nix-community / home-manager

Manage a user environment using Nix [maintainer=@rycee]
https://nix-community.github.io/home-manager/
MIT License
7.2k stars 1.85k forks source link

Allow `programs.wofi.style` to be a path to a stylesheet #5448

Open lplawlor opened 6 months ago

lplawlor commented 6 months ago

It would be nice to allow programs.wofi.style to be a path to a stylesheet or a string, instead of the current string-only requirement.

The sort of behaviour I'm suggesting is already used in programs.waybar.style for example.

For now, a workaround exists by using programs.wofi.settings.style = "${/path/to/style.css}", so this is probably low priority.

lplawlor commented 6 months ago

I think the change may be as simple as changing Line 40 of wofi.nix:

-      type = types.nullOr types.str;
+      type = types.nullOr (types.either types.path types.lines);

Though I'm not familiar enough with the difference between types.str and types.lines to know if this would break any existing configs.

stale[bot] commented 2 months ago

Thank you for your contribution! I marked this issue as stale due to inactivity. Please be considerate of people watching this issue and receiving notifications before commenting 'I have this issue too'. We welcome additional information that will help resolve this issue. Please read the relevant sections below before commenting.

If you are the original author of the issue

* If this is resolved, please consider closing it so that the maintainers know not to focus on this. * If this might still be an issue, but you are not interested in promoting its resolution, please consider closing it while encouraging others to take over and reopen an issue if they care enough. * If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

If you are not the original author of the issue

* If you are also experiencing this issue, please add details of your situation to help with the debugging process. * If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

Memorandum on closing issues

Don't be afraid to manually close an issue, even if it holds valuable information. Closed issues stay in the system for people to search, read, cross-reference, or even reopen – nothing is lost! Closing obsolete issues is an important way to help maintainers focus their time and effort.