nix-community / home-manager

Manage a user environment using Nix [maintainer=@rycee]
https://nix-community.github.io/home-manager/
MIT License
7.12k stars 1.84k forks source link

bug: firefox bookmarks are not added when policies.NoDefaultBookmarks is true #5821

Open s1n7ax opened 2 months ago

s1n7ax commented 2 months ago

Are you following the right branch?

Is there an existing issue for this?

Issue description

When using following config, bookmarks are added but when NoDefaultBookmarks = true homepage bookmark is not added.

{ ... }:
{
  programs.firefox = {
    enable = true;

    profiles.s1n7ax = {
      isDefault = true;
      bookmarks = [
        {
          name = "Nix sites";
          toolbar = true;
          bookmarks = [
            {
              name = "homepage";
              url = "https://nixos.org/";
            }
          ];
        }
      ];
    };

    policies = {
      NoDefaultBookmarks = false;
    };
  };
}

Maintainer CC

@rycee @kira-bruneau @bricked

System information

- system: `"x86_64-linux"`
 - host os: `Linux 6.6.49, NixOS, 24.11 (Vicuna), 24.11.20240906.574d1ea`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.5`
 - channels(s1n7ax): `"home-manager, nixos-23.11"`
 - channels(root): `"nixos-23.11"`
 - nixpkgs: `/nix/store/5w3dp0m37794iffsbm9vd9f1xmmhda6i-source`
brckd commented 1 month ago

Good point! This policy should be set to false if bookmarks are added.