search

nix-community / home-manager

Manage a user environment using Nix [maintainer=@rycee]
https://nix-community.github.io/home-manager/
MIT License
7.11k stars 1.83k forks source link

mbsync: update module for v1.5.0 #5884

Open antonmosich opened 1 month ago

antonmosich commented 1 month ago

isync had a new release v1.5.0 in August, and the update has been merged into nixpkgs master a few days ago (see https://github.com/NixOS/nixpkgs/pull/331813). The update introduces several breaking changes, the details of which can be seen on https://sourceforge.net/projects/isync/files/isync/1.5.0/. See #3317 as well for an issue specific to one of those changes.

Maintainer ping: @KarlJoad

KarlJoad commented 1 month ago

Looking at isync's change notes, this is what I see needs to be done on home-manager's end:

Is there anything I missed @antonmosich?

antonmosich commented 1 month ago

Thank you for the quick response. Those are the changes I noticed as well. I have some other errors appear when testing, but I think those are due to configuration errors on my side. I just didn't want to open a potentially incomplete PR, because I don't understand mbsync thoroughly enough.

KarlJoad commented 1 month ago

Feel free to drop the other errors you are getting here. I have moved off of NixOS and home-manager, so I cannot as easily test as I could in the past. I would like to get as much as I can fixed at once rather than have many issues opened one at a time.

antonmosich commented 1 month ago

I've looked into it and been able to fix it (although I think it could've been done better). The "Maildir Path cannot be nested into Inbox anymore" is the change that caused the errors. Now for my configuration it only shows the deprecation notice for SSLVersions.

peterhoeg commented 1 month ago

SSLType has also changed to TLSType

KarlJoad commented 1 month ago

From my searching, the SSLVersions option is not an explicit option that can be used (You cannot say sslVersions = [ "TLSv1.2" ... ]; somewhere. Please correct me if I am wrong, and point me in the right direction. home-manager has changed significantly since I last looked at it.

From what I see, you must set TLSVersion in an extraConfig.account attrset, which means you must rename your option. I can always add a check to alert the user, but that's the most I can do.