Closed RedEtherbloom closed 1 week ago
PR is technically ready to be merged, the only 'blocker' is the CI tests failing due to #6049
I sadly found another git-sync bug (soft) blocking this: https://github.com/simonthum/git-sync/issues/33
Thanks! Merged to master now 🙂
Description
We fixed the home-manager git-sync to properly escape the arguments that get written into the users git-sync-\<name>.service.
We additionally bumped the nixpkgs-unstable version to include our recently merged update PR for git-sync. git-sync was 2 years out of date and also had a bug with repo paths containing whitespaces.
Checklist
[x] Change is backwards compatible.
[x] Code formatted with
./format
.[x] Code tested through
nix-shell --pure tests -A run.all
ornix develop --ignore-environment .#all
using Flakes.(Excluding the four broken, non-related tests, in #6049)[x] Test cases updated/added. See example.
[x] Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC
@colonelpanic8 @cab404 @ryane