nix-community / home-manager

Manage a user environment using Nix [maintainer=@rycee]
https://nix-community.github.io/home-manager/
MIT License
7.15k stars 1.85k forks source link

Fix git-sync crash when whitespace in path #6042

Closed RedEtherbloom closed 1 week ago

RedEtherbloom commented 3 weeks ago

Description

We fixed the home-manager git-sync to properly escape the arguments that get written into the users git-sync-\<name>.service.

We additionally bumped the nixpkgs-unstable version to include our recently merged update PR for git-sync. git-sync was 2 years out of date and also had a bug with repo paths containing whitespaces.

Checklist

Maintainer CC

@colonelpanic8 @cab404 @ryane

RedEtherbloom commented 2 weeks ago

PR is technically ready to be merged, the only 'blocker' is the CI tests failing due to #6049

RedEtherbloom commented 1 week ago

I sadly found another git-sync bug (soft) blocking this: https://github.com/simonthum/git-sync/issues/33

rycee commented 1 week ago

Thanks! Merged to master now 🙂