nix-community / home-manager

Manage a user environment using Nix [maintainer=@rycee]
https://nix-community.github.io/home-manager/
MIT License
7.14k stars 1.85k forks source link

hypridle: add `systemdTarget` option #6086

Open gmvar opened 1 week ago

gmvar commented 1 week ago

Description

Checklist

Maintainer CC

@khaneliman @fufexan

khaneliman commented 1 week ago

Looks like a duplicate of https://github.com/nix-community/home-manager/pull/5981

gmvar commented 1 week ago

Looks like a duplicate of #5981

🤦

It is in fact a duplicate. My fault for not bothering to search the open PR's.

tristanbeedell commented 13 hours ago

If you want this can just orphan my PR, since something messed up the test pipelines on that branch anyway. Only difference is I also added a systemd.enable option, don't know if that necessarily would be of much value?

gmvar commented 13 hours ago

I’m okay with having this PR take over the other one. I did consider adding a systemd.enable option, but since this is a service, I’m not sure what a value of false would provide. I assume it would just generate the config? Also, since it's a service, I don’t think home-manager adds hypridle to the PATH, so that might be something to keep in mind.

I'm not opposed to adding it, so please let me know if this is an option that we would like to have.

tristanbeedell commented 12 hours ago

Cool, that's all fine by me, I'll close my PR. Thanks