nix-community / impermanence

Modules to help you handle persistent state on systems with ephemeral root storage [maintainer=@talyz]
MIT License
1.03k stars 77 forks source link

Skip generating bind mounts if no bind mounts are configured. #125

Closed ReneHollander closed 1 year ago

ReneHollander commented 1 year ago

This fixes #105 by no longer generating an empty bash function. Empty functions in bash are invalid, which cause the activation to fail.

ReneHollander commented 1 year ago

@talyz, any hints on how to get this PR reviewed?

adtya commented 1 year ago

it seems they are not very active on here

talyz commented 1 year ago

Thanks for working on a fix! Sorry for not answering faster. Real life has been taking a lot of time and energy recently, but I hope to have more to spend on impermanence soon.

talyz commented 1 year ago

Thanks!