Improve gcroots check & fix CI

nix-community / lorri

Your project’s nix-env [maintainer=@Profpatsch,@nyarly]

Apache License 2.0

639 stars 24 forks source link

Improve gcroots check & fix CI #111

Closed Profpatsch closed 3 months ago

Profpatsch commented 3 months ago

[ ] Amended the changelog in release.nix (see release.nix for instructions)

nyarly commented 3 months ago

Looking into this I've found that the per-user gcroots have been essentially deprecated; something about a conflict with a non-root nix builder? The upshot does seem to be that the preference is for any manipulation of the nix gcroots be managed by nix tools or the nix daemon, which seems sensible to me.

Elsewhere, I was taking a stab at doing that with nix build, although I think nix-store --realise (if it works) would be a better choice until the nix command leaves "experimental."

Profpatsch commented 3 months ago

I don’t think it matters very much, nix upstream is a mess. I’d rather just improve what is there right now and worry about it when upstream decides to break us.

Profpatsch commented 3 months ago

The one failing watcher test is annoying, I’m trying to figure out what’s going wrong there, but it’s gonna have to be a separate PR. So I’m merging this for now.