search

nix-community / napalm

Support for building npm packages in Nix and lightweight npm registry [maintainer=?]
MIT License
104 stars 18 forks source link

Hydra jobs continue "building" if npm errors out via napalm #3

Closed paulyoung closed 4 years ago

paulyoung commented 4 years ago

I've experienced this with both npm install and npm run test (by providing npmCommands to buildPackage)

Hydra logs end with the npm ERR! ... error output that typically appears before npm exits with a non-zero exit code, e.g. when a dependency can't be found or a test fails.

nmattia commented 4 years ago

It might be that nix is waiting for the registry to shutdown. I’ll take a look on Monday.

nmattia commented 4 years ago

Fixed in https://github.com/nmattia/napalm/commit/78cb7d391f14a33a8f7b5cfaa5ff26d97470549c

paulyoung commented 4 years ago

Thanks @nmattia!