nix-community / neovim-nightly-overlay

[maintainer=@GaetanLepage, @willruggiano]
https://matrix.to/#/#neovim-nightly-overlay:nixos.org
287 stars 40 forks source link

ISSUE: README.md has deprecated configuration argument #496

Closed DockterTeagle closed 1 month ago

DockterTeagle commented 1 month ago

Howdy,

The readme here has the use of the deprecated configuration argument. I understand if this is a very low priority issue, but it would be helpful to at least add a mention of how it should be done in latest versions of nix.

Kranzes commented 1 month ago

Can you point me to what needs to be changed (I don't use this flake like in any of the examples)? a PR would also be appreciated :)

DockterTeagle commented 1 month ago

my code is this

inputs = {
neovim-nightly-overlay.url = "github:nix-community/neovim-nightly-overlay"
};

outputs = {self,...}@inputs:
  let
  pkgs = import inputs.nixpkgs {
    system = "<your system name(like x86_64-linux)>" 
    overlays = [
      inputs.neovim-nightly-overlay.overlay
    ];
  };
in {
  homeConfigurations."username" = inputs.home-manager.lib.homeManagerConfiguration{
  modules = [./home.nix];
}; 

I removed some code which I believe is unnecessary. if this is wrong let me know. also what is wrong is this part of the code:

configuration = {pkgs,...}:
{
  nixpkgs.overlays = overlays
};

the configuration argument has been deprecated, and I can do a pull request, though I have never done this before, I guess that the correct code which follows the format of the repo code would be this:

 macbook-pro = inputs.home-manager.lib.homeManagerConfiguration {
    modules = [./home.nix];
  };
DockterTeagle commented 1 month ago

also how should I structure my commit?

DockterTeagle commented 1 month ago

pull request is opened let me know if I should change anything