nix-community / nix-doom-emacs

doom-emacs packaged for Nix [maintainers=@thiagokokada]
MIT License
213 stars 43 forks source link

fix: rm evil-collection from overrides #482

Closed roman closed 1 year ago

roman commented 1 year ago

This change was added to allow evil-collection to compile on latest versions macOS Ventura, the evil-collection version at the time of this change was halting on the compilation of the evil-collection-speedbar.el file.

Unfortunately, although this approach finishes the nix-doom emacs compilation, it leaves doom-emacs' runtime in a faulty state. The emacs package relies on a sub-directory modes that doesn't get compiled when specifying this dependency in the overrides list.

Users should override the emacsPackagesOverlay option and specify the evil-collection variable to make it work as expected on macOS Ventura. Following an example

{ pkgs, ... }:
{
  programs.doom-emacs = {
    enable = true;
    emacsPackagesOverlay = _final: _prev: {
        inherit (pkgs.emacsPackages) evil-collection;
    };
  };
}
ckiee commented 1 year ago

ref #443 for the original PR this is reverting.

roman commented 1 year ago

You didn't remove the flake input

🤦 Apologies, just did that now