nix-community / nix-eval-jobs

Parallel nix evaluator with a streamable json output [maintainers @Mic92, @adisbladis]
GNU General Public License v3.0
140 stars 26 forks source link

Remove `-fvisibility=hidden` #308

Closed lf- closed 2 months ago

lf- commented 2 months ago

FYI we found it was causing instability in the Lix fork, and we found out that it was added in the initial commit for unknown reasons. It's definitely not correct to do on libs that don't have API visibility set up. https://git.lix.systems/lix-project/nix-eval-jobs/commit/30cf61fd26894d397c3f24eed888e84acf9c9218

lf- commented 2 months ago

More investigation details here: https://gerrit.lix.systems/c/lix/+/1221