Improvements for flake usage

nix-community / nix-on-droid

Nix-enabled environment for your Android device. [maintainers=@t184256,@Gerschtli]

https://nix-on-droid.unboiled.info

MIT License

1.16k stars 65 forks source link

Improvements for flake usage #218

Closed Gerschtli closed 1 year ago

Gerschtli commented 1 year ago

This PR includes some things:

fix usage of extraSpecialArgs (we did not set the values of this argument as special arg but as _module.args which disallows usage of these values in imports in config modules)
remove parameters/simplify usage of lib.nixOnDroidConfiguration (inspired by https://github.com/nix-community/home-manager/pull/3037)
add option for text on shell startup to allow changing or removing it
add support for default config in flake, this is an easy convenience helper for people only using one device
some improvements for fakedroid environment testing

If you want me to split some commits into separate PRs, I can do that, but this may result in some merge conflicts that I tried to avoid with this big PR :)

Sorry for the high load of PRs lately, got quite some motivation and time the last weeks :) If I can make the review process easier for you, I am happy to help.

t184256 commented 1 year ago

Sorry for the high load of PRs lately, got quite some motivation and time the last weeks :)

Ahem, nothing to be sorry about. Just hope you've got some patience with me to match, as I'm the one stifling it.

If I can make the review process easier for you, I am happy to help.

If you've got a spare device to run bootstraps + on-device-tests on, doing so after PR approvals and before merging would save me time.

Regarding the PR itself, all changes look OK to me. I'm not a big fan of that part where you merge config into modules, but that's a matter of taste, I guess, and it mirrors nixosConfigurations.

Gerschtli commented 1 year ago

Ahem, nothing to be sorry about. Just hope you've got some patience with me to match, as I'm the one stifling it.

All fine, take your time :)

If you've got a spare device to run bootstraps + on-device-tests on, doing so after PR approvals and before merging would save me time.

Could do so, but these installs are really taking ages on my device. Not sure whats the reason for this. But will add a comment the PRs what I tested on device, so you don't need to do it :)

Gerschtli commented 1 year ago

Force push was only rebase on master

Gerschtli commented 1 year ago

Again only rebase on master

Gerschtli commented 1 year ago

Tested on device. Works fine. Will autosquash and merge.

That are really huge build times.. Is it just my device? :D

bootstrap channel: 15 min
run on-device-tests: 50 min
bootstrap flakes: 50 min

t184256 commented 1 year ago

Huge build times indeed. What's the device? Do you use adopted storage?

Gerschtli commented 1 year ago

It's a oneplus 5. What do you mean with adopted storage? There is no SD card or similar if you mean that.