Fix badge URL in README

nix-community / nix-ts-mode

An Emacs major mode for editing Nix expressions, powered by tree-sitter [maintainer=@remi-gelinas]

https://github.com/nix-community/nix-ts-mode

Other

50 stars 9 forks source link

Fix badge URL in README #20

Closed purcell closed 4 months ago

purcell commented 4 months ago

Struggling to see why it's helpful to have the pedantic commit / PR message checking in this very low-traffic repo. This PR was a simple doc fix via the GitHub editor.

It's not necessary to discourage casual contributors by making them re-work their PRs to fit title style guides
Since adding this checker, the only effect has been NO-ISSUE cruft in all commits

remi-gelinas commented 4 months ago

Mostly it was to ensure commits adhered to conventional spec, so automatic versioning and releases could be done. That being said, at this point I agree - it would be far simpler to manually tag for release I think, and workflow off of that. Once I've been added as the team owner for this repo again I will rework the release flow to make contribution easier.

purcell commented 4 months ago

Makes sense. Perhaps @adisbladis (as local Emacs + Nix head honcho) would be able to make you a team owner?

remi-gelinas commented 4 months ago

Yep, I've just pinged him in the original repo transfer thread again to get some eyes on it!

remi-gelinas commented 4 months ago

@purcell Realized I totally blanked and included this in #23 - sorry about that. I'll close this out as it's done!

purcell commented 4 months ago

Haha, no worries — thanks!