search

nix-community / nix-ts-mode

An Emacs major mode for editing Nix expressions, powered by tree-sitter [maintainer=@remi-gelinas]
https://github.com/nix-community/nix-ts-mode
Other
50 stars 9 forks source link

fix: correct comment syntax entry #29

Closed marsam closed 4 months ago

marsam commented 4 months ago

This was a mistakenly introduced by 3e496e8, adding the "2" flag into the comment syntax entry, caused to Emacs consider the // operator as a comment sequence:

    {
      foo = "foo";
    } // {
      bar = "bar";    # ← comment sequence
    }
purcell commented 4 months ago

Unsure why I'm not getting shown the option to merge this. Just seeing:

Screenshot 2024-05-13 at 11 09 28
Atemu commented 4 months ago

You do not appear to have write access to this repository.

purcell commented 4 months ago

Huh, okay. An oversight, @remi-gelinas ?

remi-gelinas commented 4 months ago

Odd.... Triage was the permission default set on the team for the repo. Since it says it can "manage pull requests", I assumed that was sufficient for merging. Weird - I've bumped it to Write for the teams. Can you confirm if you can merge the PR now @purcell ?

purcell commented 4 months ago

Yes, worked great, thanks! (Also merged #31)

purcell commented 4 months ago

The GitHub permission scheme is a bit confusing tbh, between team permissions, org permissions and individual repositories.