search

nix-community / nix-vscode-extensions

Nix expressions for VSCode and OpenVSX extensions [maintainers: @deemp, @AmeerTaweel]
MIT License
169 stars 9 forks source link

Introduce stable branch #19

Closed spikespaz closed 1 year ago

spikespaz commented 1 year ago

I propose that we track problematic extensions (looking at rust-analyzer) and only push these specific extensions to the stable branch when they have been checked after an automatic update.

specified: sha256-ttLGbPikx3khbjRiubNjlkEF5uX/T3NkpdpSCbELEKw=
got:       sha256-VHBxuVz7Dul/yIRnlhep3sKx9qCOOexVjLciBB1c23Y=
AmeerTaweel commented 1 year ago

Is the problem with rust-analyzer specific to some versions? If I understand correctly, the issue is that we get files for different platforms some times. In that case, this is independent of the version. Even if we test the extension and it works, a user might still get a wrong hash later.

Please correct me if I'm wrong.

spikespaz commented 1 year ago

https://github.com/nix-community/nix-vscode-extensions/issues/5

spikespaz commented 1 year ago

What versions are different? Is it random? What do you mean different platforms? I might get a vsix for a different architecture, platform, or system double?

deemp commented 1 year ago

I suggest to continue this discussion in https://github.com/nix-community/nix-vscode-extensions/issues/20