search

nix-community / nix-vscode-extensions

Nix expressions for VSCode and OpenVSX extensions [maintainers: @deemp, @AmeerTaweel]
MIT License
206 stars 11 forks source link

Consider inverting "release" and "latest" #45

Open yangm97 opened 1 year ago

yangm97 commented 1 year ago

Currently only a hand-craft set of extensions are fetched using their release versions, while everything else defaults to (almost always) preview releases. While this wouldn't be a proper fix for #41 it would improve the likelihood of finding a commit of this repo containing stable compatible extensions.

AmeerTaweel commented 1 year ago

Last week I wanted to install ms-vscode-remote.remote-ssh (Remote - SSH). Both release and latest versions were incompatible with VSCode from nixos-unstable. So as you said, this won't be a proper fix for #41.

Moreover, I think implementing this would have more drawbacks than advantages. VSCode Marketplace API responses for release extensions are much larger than their latest counterparts (as @deemp mentioned here).

yangm97 commented 1 year ago

But even if #41 was fixed, it wouldn't prevent pre-release extensions from being picked up, while it would solve the compatibility problem that would still allow unstable releases to slib by.

AmeerTaweel commented 1 year ago

I see your point now. So we should find a solution to #41 that prioritizes release extensions.