nix-community / nix-vscode-extensions

Nix expressions for VSCode and OpenVSX extensions [maintainers: @deemp, @AmeerTaweel]
MIT License
169 stars 9 forks source link

Improve overrides.nix #55

Open deemp opened 5 months ago

deemp commented 5 months ago
FraGag commented 3 months ago

https://github.com/NixOS/nixpkgs/pull/289721 was just merged into master. Once it gets merged into nixpkgs-unstable and nixos-unstable, then we'll be able to remove sourceRoot = "extension" in overrides.nix.

I advise waiting at least until it's in nixos-unstable, in case someone uses nix-vscode-extensions in a flake that changes its nixpkgs input to follow the nixos-unstable branch. If we want to be extra cautious, we could also wait for https://github.com/NixOS/nixpkgs/pull/303445, which backports the change to the release-23.11 branch.