Closed FraGag closed 3 months ago
I think this is exactly what is happening. The sort is textual. I'll see how to fix this.
@deemp Would you accept the introduction of this type? It seems like the implementation of Ord
will do right thing.
https://hackage.haskell.org/package/base-4.19.1.0/docs/Data-Version.html
@FraGag, I believe the problem is fixed now.
nix eval github:nix-community/nix-vscode-extensions/c4c7f030776a8092de2f05e339f0cd9a68e40bd8#extensions.x86_64-linux.vscode-marketplace.ms-vscode.cpptools.version
"1.20.0"
I confirm the issue is fixed. Thanks!
I detected this issue because for some extensions, I'm using the derivation from upstream nixpkgs but the extension versions from nix-vscode-extensions. I'm running NixOS so I need the patches from nixpkgs for these extensions to work, but nixpkgs is slow to update VSCode extensions, so I use nix-vscode-extensions to get updates more frequently. (Yes, this setup tends to break often.)
Since commit 9a610eef24e656d771df4097da761d458dd7fc97, the flake exposes version 1.7.1 of ms-vscode.cpptools instead of 1.20.0 on x86_64-linux:
I noticed that in
data/cache/vscode-marketplace-latest.json
, there's a line for 1.7.1 of ms-vscode.cpptools for the "universal" platform, and in commit 9a610eef24e656d771df4097da761d458dd7fc97, it moved from before the more recent platform-specific lines to after them.Looking at earlier commits, it appears the change is intentional:
However, it doesn't appear to be working as expected. Perhaps a version sort is not implemented correctly somewhere and it thinks 1.7.1 is more recent than 1.20.0? (A naïve textual sort would indeed claim so.)
cc @yacinehmito, @deemp