search

nix-community / nix-vscode-extensions

Nix expressions for VSCode and OpenVSX extensions [maintainers: @deemp, @AmeerTaweel]
MIT License
228 stars 13 forks source link

patchelf missing for vadimcn-vscode-lldb #63

Closed szinn closed 7 months ago

szinn commented 7 months ago

I believe the recent commit - https://github.com/nix-community/nix-vscode-extensions/commit/88eb88c27b28cab7a7c08e3bfa392b0205dbe9dd added a dependency on patchelf which is now missing.

Should it have been pkgs.patchelf?

       last 11 log lines:
       > Running phase: unpackPhase
       > unpacking source archive /nix/store/gy7q5dwagzqjvxgkv1pg7d8s7j9jyvxv-vscode-lldb-v1.10.0.zip
       > source root is extension
       > setting SOURCE_DATE_EPOCH to timestamp 1694803328 of file extension/README.md
       > Running phase: patchPhase
       > Running phase: updateAutotoolsGnuConfigScriptsPhase
       > Running phase: configurePhase
       > Running phase: buildPhase
       > Running phase: installPhase
       > /nix/store/9kswmdwjwz05aawgcbxg9krsxq00rgih-stdenv-darwin/setup: line 124: patchelf: command not found
       > /nix/store/9kswmdwjwz05aawgcbxg9krsxq00rgih-stdenv-darwin/setup: line 140: pop_var_context: head of shell_variables not a function context
       For full logs, run 'nix log /nix/store/5yag9pikhrlzx0kh2c8lvwg043kzi02y-vscode-extension-vadimcn-vscode-lldb-v1.10.0.drv'.
szinn commented 7 months ago

Issue is actually that the patch should not be applied on Darwin systems. PR #64 submitted