search

nix-community / nix-zsh-completions

ZSH Completions for Nix
BSD 3-Clause "New" or "Revised" License
228 stars 31 forks source link

Remove _nixpkgs-review because upstream now has completions #45

Closed Janik-Haag closed 1 year ago

Janik-Haag commented 1 year ago

We should remove _nixpkgs-review since upstream now has it's own https://github.com/Mic92/nixpkgs-review/pull/296 completions. And currently a conflict breaks nixpkgs for people having nixpkgs-review and zsh enabled since these completions get added by default: 

> error: collision between `/nix/store/ks3jyjkhy10aypk4w7w4rxhcl7iv0dm5-nixpkgs-review-2.10.0/share/zsh/site-functions/_nixpkgs-review' and `/nix/store/si3z4ygv3zrs8ja6n87frl8w5m1a80hm-nix-zsh-completions-unstable-2023-01-30/share/zsh/site-functions/_nixpkgs-review'
Janik-Haag commented 1 year ago

Fixed my username and email, now the commit says verified again :see_no_evil: